N°8955 add UI block for uninstallation#797
Merged
Timmy38 merged 13 commits intofeature/uninstallationfrom Feb 27, 2026
Merged
Conversation
steffunky
requested changes
Jan 20, 2026
|
|
||
| .ibo-extension-details--actions > button{ | ||
| position:relative; | ||
| top:-3px; |
Member
There was a problem hiding this comment.
What's the point of the top: -3px ?
If we need to position flex element we can probably use justify-* or align-*
Contributor
Author
There was a problem hiding this comment.
The button for the menu had padding that made it bigger. I changed it to correct the padding instead of changing the position.
sources/Application/UI/Base/Layout/Extension/ExtensionDetails.php
Outdated
Show resolved
Hide resolved
sources/Application/UI/Base/Layout/Extension/ExtensionDetailsFactory.php
Outdated
Show resolved
Hide resolved
sources/Application/UI/Base/Layout/Extension/ExtensionDetailsFactory.php
Outdated
Show resolved
Hide resolved
templates/base/layouts/extension/extension-details/layout.ready.js.twig
Outdated
Show resolved
Hide resolved
Contributor
|
@Timmy38 regarding the formatting of the SCSS, in PHPStorm hit |
CombodoApplicationsAccount
force-pushed
the
feature/8955_add_UIBlock_for_uninstallation
branch
from
46451a3 to
6dc8cef
Compare
Contributor
|
Discussed with Timothée IRL, we stay focused on the setup wizard for now, integration of the UIBlocks will be done afterwards. |
CombodoApplicationsAccount
force-pushed
the
feature/8955_add_UIBlock_for_uninstallation
branch
from
36e3a0a to
f106c98
Compare
steffunky
reviewed
Feb 26, 2026
dictionaries/ui/layouts/extensions-details/en.dictionary.itop.extensions-details.php
Show resolved
Hide resolved
sources/Application/UI/Base/Layout/Extension/ExtensionDetails.php
Outdated
Show resolved
Hide resolved
sources/Application/UI/Base/Layout/Extension/ExtensionDetails.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.